Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ACM modules #1263

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Rename ACM modules #1263

merged 3 commits into from
Jun 25, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 25, 2022 •
edited
Loading

SUMMARY

In line with what I understood to be the consensus on ansible-collections/amazon.aws#881 and ansible-collections/amazon.aws#610

Rename aws_acm to acm_certificate
Rename aws_acm_info to acm_certificate_info

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_acm
aws_acm_info
acm_certificate
acm_certificate_info

ADDITIONAL INFORMATION

@github-actions

This comment was marked as outdated.

Sign in to view
@ansibullbot
Copy link

cc @jillr @markuman @s-hertel
click here for bot help

@ansibullbot ansibullbot added community_review docs feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jun 25, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 5m 11s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 45s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 48s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 40s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 08s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 35s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 22s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 36s
✔️ ansible-test-splitter SUCCESS in 2m 50s
✔️ integration-community.aws-1 SUCCESS in 8m 08s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble changed the title Rename aws_acm to acm_certificate Rename ACM modules Jun 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 3m 41s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 09s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 16s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 14s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 23s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 02s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 35s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 11s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-community.aws-1 SUCCESS in 9m 27s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ba08f90 into ansible-collections:main Jun 25, 2022
@tremble tremble deleted the renames/acm_certificate branch July 7, 2022 19:26
@renovate renovate bot mentioned this pull request Oct 6, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

@jatorcasso jatorcasso Awaiting requested review from jatorcasso

Assignees
No one assigned
Labels
community_review docs feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @markuman